[FLINK-3975] [docs] Override baseurl when serving docs locally #2040
Conversation
|
@uce Can you have a look at this? |
| @@ -54,7 +54,7 @@ JEKYLL_CMD="build" | |||
| while getopts ":p" opt; do | |||
| case $opt in | |||
| p) | |||
| JEKYLL_CMD="serve --config _config.yml,_local_preview_conf.yml --watch" | |||
| JEKYLL_CMD="serve --baseurl= --watch" | |||
There was a problem hiding this comment.
Thanks! Just tried this out and it works as expected. I guess it was there, because older Jekyll versions didn't have support for this. @dyanarose, do know exactly what changed (if anything) between Jekyll versions?
+1 to apply this change after #2033 has been merged.
There was a problem hiding this comment.
@uce It looks like the baseurl switch came in with 1.0 https://github.com/jekyll/jekyll/blob/0ee1a75d16265abc250d0747c5f93bf2ad2daa05/site/_docs/upgrading/0-to-2.md#baseurl.
I think serve not respecting the multiple config files may be a bug/feature with Jekyll as the docs say that serve takes all the same switches as build does. https://jekyllrb.com/docs/configuration/#serve-command-options. I'm looking to prove that when I get the chance and look into it to raise an issue to see if the code or the docs need changing.
There was a problem hiding this comment.
Thanks for the explanation :-) I'll merge this later today
Updating build_docs.sh to serve the docs locally with the correct url.
This change makes build_docs.sh run the equivalent serve command to build_docs.bat.
removing now unnecessary config file.