[FLINK-4025] Add possiblity for the RMQ Streaming Source to customize the queue #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds the possibilty for th user of the RabbitMQ Streaming Connector to customize the queue which is used. There are use-cases in which you want to set custom parameters for the queue (i.e. TTL of the messages if Flink reboots) or the possibility to bind the queue to an exchange afterwards. The commit doesn't change the actual behaviour but makes it possible for users to override the newly create `setupQueue` method and cutomize their implementation. This was not possible before.
|
The change looks good, I'll merge it. |
rmetzger
pushed a commit
to rmetzger/flink
that referenced
this pull request
Jun 7, 2016
This patch adds the possibilty for th user of the RabbitMQ Streaming Connector to customize the queue which is used. There are use-cases in which you want to set custom parameters for the queue (i.e. TTL of the messages if Flink reboots) or the possibility to bind the queue to an exchange afterwards. The commit doesn't change the actual behaviour but makes it possible for users to override the newly create `setupQueue` method and cutomize their implementation. This was not possible before. This closes apache#2073
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the possibilty for the user of the RabbitMQ
Streaming Connector to customize the queue which is used. There
are use-cases in which you want to set custom parameters for the
queue (i.e. TTL of the messages if Flink reboots) or the
possibility to bind the queue to an exchange afterwards.
The commit doesn't change the actual behaviour but makes it
possible for users to override the newly create
setupQueuemethod and cutomize their implementation. This was not possible
before.