-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-30636] [docs]: Typo fix; 'to to' -> 'to' #21648
Conversation
// CC @rmetzger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to merge once CI has passed
The PR doesn't build:
|
@@ -186,7 +186,7 @@ public interface Environment { | |||
TaskKvStateRegistry getTaskKvStateRegistry(); | |||
|
|||
/** | |||
* Confirms that the invokable has successfully completed all steps it needed to to for the | |||
* Confirms that the invokable has successfully completed all steps it needed to for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zero to
might even be better here!
* Confirms that the invokable has successfully completed all steps it needed to for the | |
* Confirms that the invokable has successfully completed all steps it needed for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, do you really think so? I'm not a native English speaker, but it seems right to me, judging by reverting the order of the sentence parts: "for the checkpoint, it completed to steps it needed to".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I'm originally anglophone, but not a great editor! We didn't learn much grammar, and trying to search for the correct grammar has led me down a rabbit hole of semi-modal verbs that probably isn't worth it :D While validating the PR this one stuck out to me, but a single to
isn't wrong, so LGTM either way!
1b6d9da
to
fd00870
Compare
Force-pushed an update to apply the formatter. |
@rmetzger, could we get this one merged? |
@rmetzger, gentle ping. |
Ah, sorry for the oversight! |
Just a fix of a surprisingly common typo in JavaDoc etc.
https://issues.apache.org/jira/browse/FLINK-30636