Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-21000][runtime] Add an internal split enumerator metric group #21952

Closed
wants to merge 2 commits into from

Conversation

ruanhang1993
Copy link
Contributor

What is the purpose of the change

This pull request adds an internal split enumerator metric group.

Brief change log

  • Add InternalOperatorEnumeratorMetricGroup
  • make SourceCoordinatorContext#metricGroup return an instance of InternalOperatorEnumeratorMetricGroup
  • Define the metric name 'unassignedSplits' in MetricNames

Verifying this change

This change added unit tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not documented

@ruanhang1993 ruanhang1993 changed the title [FLINK-2100][runtime] Add an internal split enumerator metric group [FLINK-21000][runtime] Add an internal split enumerator metric group Feb 16, 2023
@ruanhang1993
Copy link
Contributor Author

Hi, @zentol , this is the metric group for the SplitEnumerator. Please take a look if you have time. Thanks~

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 16, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

"jobmanager",
"myJobName",
"opName",
"coordinator",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it implemented by the other PR and is outside the scope of this PR. curious about both coordinator and enumerator. kind of redundant to me. do we have components (other than enumerator) under coordinator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SplitEnumerator is the main component in the SourceCoordinator.I think it is clearer for the relationship between them with the name enumerator. Removing it is also fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all coordinator contains enumerator component, I think keep both of them is more clear.

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ruanhang1993 for the contribution, LGTM

mohsenrezaeithe pushed a commit to mohsenrezaeithe/flink that referenced this pull request Feb 21, 2023
mas-chen pushed a commit to mas-chen/flink that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants