-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-21000][runtime] Add an internal split enumerator metric group #21952
Conversation
Hi, @zentol , this is the metric group for the SplitEnumerator. Please take a look if you have time. Thanks~ |
...rc/main/java/org/apache/flink/runtime/metrics/groups/InternalSplitEnumeratorMetricGroup.java
Outdated
Show resolved
Hide resolved
"jobmanager", | ||
"myJobName", | ||
"opName", | ||
"coordinator", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it implemented by the other PR and is outside the scope of this PR. curious about both coordinator
and enumerator
. kind of redundant to me. do we have components (other than enumerator) under coordinator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SplitEnumerator is the main component in the SourceCoordinator.I think it is clearer for the relationship between them with the name enumerator
. Removing it is also fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not all coordinator
contains enumerator
component, I think keep both of them is more clear.
ed16e31
to
a0f1626
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ruanhang1993 for the contribution, LGTM
…cGroup This closes apache#21952.
…torMetricGroup This closes apache#21952.
What is the purpose of the change
This pull request adds an internal split enumerator metric group.
Brief change log
Verifying this change
This change added unit tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation