Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-4196] [runtime] Remove recovery timestamp from checkpoint restores #2243

Closed

Conversation

StephanEwen
Copy link
Contributor

The 'recoveryTimestamp' was an unsafe wall clock timestamp attached by the master upon recovery. Because this timestamp cannot be relied upon in distributed setups, it is removed here.

If we need something like this in the future, we should try and get a globally progress counter or logical timestamp instead.

No code in the core Flink repository is affected by this change.

… restores.

The 'recoveryTimestamp' was an unsafe wall clock timestamp attached by the master
upon recovery. This this timestamp cannot be relied upon in distributed setups,
it is removed.
@uce
Copy link
Contributor

uce commented Jul 14, 2016

Changes look good. Travis build failure is unrelated in two jobs of the build.

+1 to merge, commit c738fcd has a typo in the commit message though (missing e at the end of [runtim])

@zentol
Copy link
Contributor

zentol commented Jul 15, 2016

@StephanEwen Could you close the PR, since you already merged it?

@StephanEwen
Copy link
Contributor Author

Yes, thanks!

Manually merged in de6a3d3

@StephanEwen StephanEwen deleted the remove_recovery_timestamp branch August 1, 2016 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants