Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-31881][docs] Fix the confusion in the Chinese documentation page of Flink official CEP, and add the Scala code of timesOrMore. #22452

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

zzzzzzzs
Copy link
Contributor

Brief change log

fix the typo in docs/content/docs/libs/cep.md
fix the typo in docs/content.zh/docs/libs/cep.md

…ge of Flink official CEP, and add the Scala code of timesOrMore.
@flinkbot
Copy link
Collaborator

flinkbot commented Apr 22, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@zzzzzzzs zzzzzzzs changed the title [FLINK-31799][docs] Fix the confusion in the Chinese documentation page of Flink official CEP, and add the Scala code of timesOrMore. [FLINK-31881][docs] Fix the confusion in the Chinese documentation page of Flink official CEP, and add the Scala code of timesOrMore. Apr 23, 2023
Comment on lines 480 to 484
{{< tab "Scala" >}}
```scala
pattern.timesOrMore(2)
```
{{< /tab >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that Scala is deprecated for Flink, I'm really wondering if we should add more code examples for Scala

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, as Flink has deprecated Scala, I have removed this section from the document.

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants