[FLINK-31950][table-planner] Introduce StateMetadata and StateMetadataJson SerDe #22492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flinkbot run azure |
LadyForest
force-pushed
the
FLINK-31950
branch
2 times, most recently
from
826bf4c
to
5889eeb
Compare
|
Since it's a huge change, let's separate this PR into several smaller PRs to ease the review. |
LadyForest
changed the title
LadyForest
commented
May 11, 2023
...able-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/StateMetadata.java
Outdated
Show resolved
Hide resolved
...able-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/StateMetadata.java
Outdated
Show resolved
Hide resolved
godfreyhe
reviewed
May 12, 2023
...ble-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeConfig.java
Outdated
Show resolved
Hide resolved
...able-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/StateMetadata.java
Show resolved
Hide resolved
...n/java/org/apache/flink/table/planner/plan/nodes/exec/serde/StateMetadataJsonSerializer.java
Outdated
Show resolved
Hide resolved
godfreyhe
approved these changes
May 15, 2023
| Preconditions.checkNotNull(stateName, "state name should not be null")); | ||
| } | ||
|
|
||
| public StateMetadata(int stateIndex, @Nonnull Duration stateTtl, @Nonnull String stateName) { |
There was a problem hiding this comment.
nit: @Nonnull will check null value when running, you can improve it in the following prs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This is the first subtask of FLINK-31791 for FLIP-292.
Brief change log
This PR introduces
StateMetadata, which describes the operator's state info, alongside withStateMetadataJsonSerializerandStateMetadataJsonDeserializer.Verifying this change
This change added tests and can be verified as follows:
StateMetadataTestto verify the JsonSerde works as expected.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation