[FLINK-31993][runtime] Initialize and pass down FailureEnrichers #22516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgaref
changed the title
pgaref
force-pushed
the
FLINK-31993
branch
2 times, most recently
from
74fbcfa
to
bdae163
Compare
dmvk
reviewed
May 25, 2023
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/flink/runtime/jobmaster/factories/DefaultJobMasterServiceFactory.java
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherServices.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/failure/FailureEnricherUtils.java
Outdated
Show resolved
Hide resolved
* Init FailureEnrichers as part of ClusterEntrypoint
Awesome! Thanks @dmvk ! Updated |
dmvk
approved these changes
May 31, 2023
| @@ -561,6 +561,7 @@ private void setupDispatcherResourceManagerComponents( | |||
| metricRegistry, | |||
| new MemoryExecutionGraphInfoStore(), | |||
| metricQueryServiceRetriever, | |||
| Collections.emptySet(), | |||
There was a problem hiding this comment.
What's the reason for not supporting the minicluster?
There was a problem hiding this comment.
Will be done as part of FLINK-31895
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/FLINK-31993
The set of Enrichers is then passed down to JM and Scheduler implementations as needed.