[FLINK-32219][sql-client] Fix SqlClient hangs when executing EXECUTE PLAN statement #22703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fsk119, could you help to review the fix when you're available? |
fsk119
reviewed
Jun 6, 2023
...ateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java
Outdated
Show resolved
Hide resolved
...ateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java
Outdated
Show resolved
Hide resolved
LadyForest
added a commit
to LadyForest/flink
that referenced
this pull request
Jun 7, 2023
…PLAN statement (apache#22703) (cherry picked from commit 83ba6b5)
xiangyuf
pushed a commit
to xiangyuf/flink
that referenced
this pull request
Dec 13, 2023
* [FLINK-32396][jdbc-driver] Support timestamp and timestamp_ltz for jdbc driver… * [FLINK-33000][sql-gateway] SqlGatewayServiceITCase should utilize… * [FLINK-33000][sql-gateway] OperationManagerTest should utilize… * [FLINK-33000][sql-gateway] ResultFetcherTest should utilize… * [FLINK-32219][sql-client] Fix SqlClient hangs when executing EXECUTE PLAN statement (apache#22703) * [FLINK-31956][table] Extend COMPILE PLAN statement to read/write from/to Flink FileSystem * [FLINK-32661][sql-gateway] Fix unstable OperationRelatedITCase.testOperationRelatedApis * [FLINK-32512][table] Don't register resource to user resource manager when… * [FLINK-32309][sql-gateway] Use independent resource manager for table environment (apache#22768) * fix * [FLINK-32299][gateway] Upload python jar when sql contains python udf jar * [FLINK-31956][table-planner] Fix COMPILE PLAN statement fails to write to file… https://code.byted.org/inf/flink/merge_requests/5796
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR fixes the issue that the
COMPILE AND EXECUTE PLANorEXECUTE PLANstatement causes the SQL client to hang forever. The reason is thatOperationExecutordidn't take these two kinds of operation kind into account. Instead, they should be dealt with likeModifyOperation.Brief change log
OperationExecutorcope withExecutionPlanOperationandCompileAndExecutePlanOperation.TableEnvironmentImplshould applyTABLE_DML_SYNCfor bothModifyOpeartionandExecutePlanOperation. Both of them are compiled frominsert intoqueries.Verifying this change
insert.qto verify that theEXECUTE PLANandCOMPILE AND EXECUTE PLANstatements work as expected after the fix.EXECUTE PLANstatement.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation