[FLINK-32495][connectors/common] Fix the bug that the shared thread factory causes the source alignment unit test to fail #22911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actory causes the source alignment unit test to fail
1996fanrui
force-pushed
the
32495/shared-coordinator-thread-factory-18
branch
from
3c4c809
to
e62427b
Compare
1996fanrui
force-pushed
the
32495/shared-coordinator-thread-factory-18
branch
from
e62427b
to
85b96a1
Compare
RocMarshal
reviewed
Jun 30, 2023
There was a problem hiding this comment.
Hello, @1996fanrui , Thanks for your driving the fix.
That looks good to me.
| @Before | ||
| public void setup() { | ||
| @BeforeEach | ||
| void setup() { | ||
| provider = | ||
| new SourceCoordinatorProvider<>( | ||
| "SourceCoordinatorProviderTest", |
There was a problem hiding this comment.
How about
Suggested change
| "SourceCoordinatorProviderTest", | |
| this.getClass().getSimpleName(), |
?
There was a problem hiding this comment.
it's not related to this fix, and this fix is urgent, so i will merge it first.
Comment on lines
+126
to
+139
| @Test | ||
| void testCoordinatorExecutorThreadFactoryNewMultipleThread() { | ||
| SourceCoordinatorProvider.CoordinatorExecutorThreadFactory | ||
| coordinatorExecutorThreadFactory = | ||
| new SourceCoordinatorProvider.CoordinatorExecutorThreadFactory( | ||
| "test_coordinator_thread", | ||
| new MockOperatorCoordinatorContext( | ||
| new OperatorID(1234L, 5678L), 3)); | ||
|
|
||
| coordinatorExecutorThreadFactory.newThread(() -> {}); | ||
| // coordinatorExecutorThreadFactory cannot create multiple threads. | ||
| assertThatThrownBy(() -> coordinatorExecutorThreadFactory.newThread(() -> {})) | ||
| .isInstanceOf(IllegalStateException.class); | ||
| } |
Comment on lines
+138
to
+141
| checkState( | ||
| t == null, | ||
| "Please using the new CoordinatorExecutorThreadFactory," | ||
| + " this factory cannot new multiple threads."); |
There was a problem hiding this comment.
nice~.
This design is in line with the principle that It should fail first once encounter error operation.
|
Hi @snuyanzin @RocMarshal , thanks for the quick review, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
SourceCoordinatorAlignmentTest.testWatermarkAlignmentWithTwoGroups fails.
I analyzed this CI : https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=50668&view=logs&j=a57e0635-3fad-5b08-57c7-a4142d7d6fa9&t=2ef0effc-1da1-50e5-c2bd-aab434b1c5b7&l=9089
Root cause:
coordinatorThreadFactory.isCurrentThreadCoordinatorThread(), such as: SourceCoordinatorContext.attemptReady.Brief change log
Don't share the CoordinatorExecutorThreadFactory.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation