Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-32623] Return correct vertex resource lower bound #23014

Merged
merged 1 commit into from
Jul 19, 2023
Merged

[FLINK-32623] Return correct vertex resource lower bound #23014

merged 1 commit into from
Jul 19, 2023

Conversation

gyfora
Copy link
Contributor

@gyfora gyfora commented Jul 18, 2023

What is the purpose of the change

Return actual minimum parallelism bound instead of hardcoded 1.

Verifying this change

Extended existing unit tests to cover this case.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@gyfora gyfora requested review from dmvk and zentol July 18, 2023 14:12
@flinkbot
Copy link
Collaborator

flinkbot commented Jul 18, 2023 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@zentol
Copy link
Contributor

zentol commented Jul 19, 2023

@flinkbot run azure

1 similar comment
@gyfora
Copy link
Contributor Author

gyfora commented Jul 19, 2023

@flinkbot run azure

@zentol zentol merged commit 6b3d291 into apache:master Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zentol zentol zentol approved these changes

@dmvk dmvk Awaiting requested review from dmvk

Assignees
No one assigned
Labels
component=Runtime/REST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gyfora @flinkbot @zentol