[FLINK-32689] Improve validation of local time zone

[twalthr]

What is the purpose of the change

This fixes the insufficient validation of ZoneId for setting local time zones.

Brief change log

• It ensures that no information is lost when converting between TimeZone and ZoneId
• Now time zones such as UT-1 fail with an error.
• ZoneOffset is converted to GMT zone in order to avoid issues where the offset is lost when converting between TimeZone and ZoneId

Verifying this change

This change added tests and can be verified as follows:

• TableConfigTest

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? not applicable

[flinkbot]

CI report:

• a9a21dd Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[dawidwys]

What are the offending places? Wouldn't it be better to simply remove all places where we convert to java.util.TimeZone? From a quick look, there is only one such place (RexNodeExtractor) and even there in the end we convert back to ZoneId.

[twalthr]

@dawidwys I totally agree that ZoneId would be enough everywhere. But this is currently not feasible. Checkout DateTimeUtils and the code generation. Let's open a followup issue for this. In general, it makes sense to limit input such that any util (backed by legacy or new zones) can work with it. I just saw that even FileSystemTableFactory needs to be updated.

[dawidwys]

But neither DateTimeUtils nor FileSystemTableFactory use the time zone setting from TableConfig.

• FileSystemTableFactory uses: SINK_PARTITION_COMMIT_WATERMARK_TIME_ZONE, which has separate validation and doesn't go through ZoneId.
• DateTimeUtils are used in builtin functions which is applied on incoming data.

I am not insisting on making the change now though...

[dawidwys]

LGTM, since it improves the validation