Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-32713] Cascade deprecation to non-private methods that reference SourceFunction #23105

Merged
merged 1 commit into from
Aug 9, 2023
Merged

[FLINK-32713] Cascade deprecation to non-private methods that reference SourceFunction #23105

merged 1 commit into from
Aug 9, 2023

Conversation

afedulov
Copy link
Contributor

@afedulov afedulov commented Jul 31, 2023 •
edited
Loading

This is a trivial change that marks non-private methods that reference SourceFunction as @Deprecated.

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 31, 2023 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@afedulov afedulov changed the title [FLINK-32670] Cascade deprecation to classes that implement SourceFunction [FLINK-32713] Cascade deprecation to non-private methods that reference SourceFunction Jul 31, 2023
@afedulov afedulov force-pushed the 32713-deprecate-methods branch 2 times, most recently from baf8c90 to 765aeb3 Compare August 3, 2023 12:46
@afedulov
Copy link
Contributor Author

afedulov commented Aug 3, 2023

@flinkbot run azure

1 similar comment
@afedulov
Copy link
Contributor Author

afedulov commented Aug 4, 2023

@flinkbot run azure

@leonardBang leonardBang self-requested a review August 7, 2023 15:50
leonardBang
leonardBang reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI failed, I guess you need to enable freeze.store.default.allowStoreCreation=true temporarily and then use produced violations files, see more here:

flink/flink-architecture-tests/flink-architecture-tests-production/src/test/resources/archunit.properties

Line 22 in 8c9b176

# Enable this if a new (frozen) rule has been added in order to create the initial store and record the existing violations.

@leonardBang
Copy link
Contributor

The CI issue resolved, cool. But there're conflicts which we need to fix, plz rebase to latest master(or maybe we need to wait another PR merge firstly).

@afedulov
Copy link
Contributor Author

afedulov commented Aug 8, 2023 •
edited
Loading

@leonardBang done, thanks for the hint for the ArchUnit fix.

@afedulov
Copy link
Contributor Author

afedulov commented Aug 8, 2023

@flinkbot run azure

@leonardBang
Copy link
Contributor

I merged previous PR #23079 , now it's time to rebase this one @afedulov ^_^

@afedulov
Copy link
Contributor Author

afedulov commented Aug 8, 2023

@leonardBang CI is green.

leonardBang
leonardBang approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @afedulov for the contribution, LGTM

@leonardBang leonardBang merged commit 3be0781 into apache:master Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardBang leonardBang leonardBang approved these changes

Assignees
No one assigned
Labels
component=Connectors/Common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afedulov @flinkbot @leonardBang