Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-32912][release] Build 1.18 docs in GitHub Action #23258

Merged
merged 2 commits into from
Aug 23, 2023
Merged

[FLINK-32912][release] Build 1.18 docs in GitHub Action #23258

merged 2 commits into from
Aug 23, 2023

Conversation

JingGe
Copy link
Contributor

@JingGe JingGe commented Aug 22, 2023

No description provided.

@JingGe JingGe requested a review from PatrickRen August 22, 2023 13:23
snuyanzin
snuyanzin approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 22, 2023 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

PatrickRen
PatrickRen reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think this should be merged when we finalize the release after the RC and voting procedure.

@JingGe
Copy link
Contributor Author

JingGe commented Aug 22, 2023

@flinkbot run azure

1 similar comment
@JingGe
Copy link
Contributor Author

JingGe commented Aug 22, 2023

@flinkbot run azure

@JingGe JingGe changed the title [FLINK-32912][release] Build 1.18 docs in GitHub Action and mark 1.18 as stable in docs [FLINK-32912][release] Build 1.18 docs in GitHub Action Aug 23, 2023
PatrickRen
PatrickRen requested changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JingGe I checked the history in 1.16. We need to keep release-1.17 as the latest stable version for now.

.github/workflows/docs.yml Show resolved Hide resolved
PatrickRen
PatrickRen approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you rebase the latest master and wait for the CI result (at least the compile stage)?

@JingGe JingGe force-pushed the FLINK-32912-manage-doc-1.18 branch from 0d6b7fa to 3f13d8b Compare August 23, 2023 08:33
@JingGe JingGe merged commit 582457c into apache:master Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardBang leonardBang leonardBang left review comments

@PatrickRen PatrickRen PatrickRen approved these changes

@snuyanzin snuyanzin snuyanzin approved these changes

Assignees
No one assigned
Labels
component=<none>
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JingGe @flinkbot @snuyanzin @leonardBang @PatrickRen