Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-33084][runtime] Migrate globalJobParameter to configuration. #23409

Closed
wants to merge 1 commit into from
Closed

[FLINK-33084][runtime] Migrate globalJobParameter to configuration. #23409

wants to merge 1 commit into from

Conversation

JunRuiLee
Copy link
Contributor

What is the purpose of the change

Migrate globalJobParameter to configuration.

Brief change log

Migrate globalJobParameter to configuration.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 13, 2023 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

zhuzhurk
zhuzhurk approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you rebase it to the latest master?

@JunRuiLee JunRuiLee force-pushed the Migrate_globalJobParameter_to_configuration branch from 20e1f35 to 74c6b68 Compare October 27, 2023 10:26
@JunRuiLee
Copy link
Contributor Author

@zhuzhurk Thank you for your review! I've rebased the code to the latest master.

@zhuzhurk zhuzhurk closed this in b946ecc Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuzhurk zhuzhurk zhuzhurk approved these changes

Assignees
No one assigned
Labels
component=Runtime/Configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JunRuiLee @flinkbot @zhuzhurk