Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33128] Add converter.open() method call on TestValuesRuntimeFunctions #23453

Closed
wants to merge 3 commits into from

Conversation

jgagnon1
Copy link
Contributor

What is the purpose of the change

Make sure complex type such as Array<Row<>> get converted property in TestValues connector when doing lookup joins.

Brief change log

  • Added a call to concerter.open() on TestValuesRuntimeFunctions (sync and sync)

Verifying this change

This change added tests and can be verified as follows:

  • Added integration tests for lookup join with Array<Row<>> on lookup table.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@jgagnon1 jgagnon1 changed the title [FLINK-33218] Add converter.open() method on TestValuesRuntimeFunctions [FLINK-33128] Add converter.open() method on TestValuesRuntimeFunctions Sep 22, 2023
@jgagnon1 jgagnon1 changed the title [FLINK-33128] Add converter.open() method on TestValuesRuntimeFunctions [FLINK-33128] Add converter.open() method call on TestValuesRuntimeFunctions Sep 22, 2023
@flinkbot
Copy link
Collaborator

flinkbot commented Sep 22, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@jgagnon1
Copy link
Contributor Author

jgagnon1 commented Oct 3, 2023

@flinkbot run azure

Copy link
Member

@xccui xccui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@gaoyunhaii
Copy link
Contributor

@flinkbot run azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants