Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33344][rpc] Replace Time with Duration in RpcInputSplitProvider #23575

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

Jiabao-Sun
Copy link
Contributor

What is the purpose of the change

[FLINK-33344][rpc] Replace Time with Duration in RpcInputSplitProvider

Brief change log

[FLINK-33344][rpc] Replace Time with Duration in RpcInputSplitProvider

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 24, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

fyi: There is FLIP-335 in discussion that's going to confirm the clean up even for public API. Maybe, we can do this in a more structured way (i.e. all at once) then when it's accepted rather than individual PRs.

@Jiabao-Sun
Copy link
Contributor Author

LGTM 👍

fyi: There is FLIP-335 in discussion that's going to confirm the clean up even for public API. Maybe, we can do this in a more structured way (i.e. all at once) then when it's accepted rather than individual PRs.

Got it, thanks a lot.

@XComp XComp merged commit 22c1eb4 into apache:master Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants