Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP-1.17][FLINK-33346][runtime][test] Removes timeout #23580

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

XComp
Copy link
Contributor

@XComp XComp commented Oct 24, 2023

1.17 backport for parent PR #23578

The instability is caused by the timeout. The fatal error hides the actual cause (i.e. the TimeoutException). It can be reproduced by setting the timeout of the test to 0ms. The actual cause is revealed when disabling the fatal error handling or not throwing a AssertionError in case of the fatal error.
@XComp XComp changed the title [FLINK-33346][runtime][test] Removes timeout [BP-1.17][FLINK-33346][runtime][test] Removes timeout Oct 24, 2023
@flinkbot
Copy link
Collaborator

flinkbot commented Oct 24, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@XComp
Copy link
Contributor Author

XComp commented Oct 24, 2023

FLINK-18356 issue caused both CI failure

@XComp
Copy link
Contributor Author

XComp commented Oct 24, 2023

@flinkbot run azure

@XComp XComp merged commit 06db375 into apache:release-1.17 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants