[BP-1.17][FLINK-18356] Update CI image

[XComp]

What is the purpose of the change

1.17 backport PR for parent PR #23717

Brief change log

I also backport the change for the docs build for the sake of consistency even though it's not necessary to fix FLINK-18356.

This backport required the upgrade of Maven to 3.8.6 (FLINK-28203).

Verifying this change

CI should pass without problems and should include the optional check

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? not applicable

[flinkbot]

CI report:

• be3c880 Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[XComp]

@flinkbot run azure

[XComp]

The license check failure cannot be reproduced locally. Let's see whether it's reproducible in CI.

[XComp]

I cannot get my head around why just upgrading the Docker image (4ae9836) leads to a LicenseCheck failure. We have to backport FLINK-32834 and FLINK-28203 to fix CI.

Update: Ok, looking into the issues: FLINK-28203 has to be backported because of the Maven version update. But the LicenseChecker issue seems to be unrelated. I still have to investigate whether FLINK-32834 is actually not needed.

Update 2: Looks like backporting FLINK-32834 is actually not necessary and I was misguided by error initially.

[snuyanzin]

Thanks for driving this 👍

After looking at FLINK-28203 i noticed that there are also files
tools/ci/compile.sh
tools/ci/maven-utils.sh
tools/ci/verify_bundled_optional.sh

shouldn't they also be part of this PR?

[XComp]

After looking at FLINK-28203 i noticed that there are also files
tools/ci/compile.sh
tools/ci/maven-utils.sh
tools/ci/verify_bundled_optional.sh

shouldn't they also be part of this PR?

You're right. Thanks for this thorough review. I screwed up the backports. But anyway, @zentol pushed a dedicated image for the release-1.17 branch that includes Maven 3.2.5 which I'm gonna use now. That makes life easier. 8)

[snuyanzin]

nit:
should we refer to concrete image here?
I'm asking since now there is a new one available chesnay/flink-ci:java_8_11_17_21_maven_386 which potentially could be used for 1.19

[XComp]

Good point - I had the naive view that we won't change the Docker image anymore until the EOL of 1.17 :-D

[snuyanzin]

Thanks for the update
it looks good from my side,
I left a minor comment however it's up to you to ignore it or not