Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33705] Upgrade to flink-shaded 18.0 #23838

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

snuyanzin
Copy link
Contributor

What is the purpose of the change

The PR is to bump flink-shaded dependency to 18.0
Also there was a breaking change in jackson-databind FasterXML/jackson-databind#3651
which moves the logic for scientific notation from JsonNodeFactory to JsonNodeDeserializer. The problem is that in flink-csv and flink-json for converters bare JsonNodeFactory is used and this is impacted. The PR adopts the code

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes )
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes )
  • The serializers: ( no)
  • The runtime per-record code paths (performance sensitive): ( no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
  • The S3 file system connector: ( no )

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 30, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@snuyanzin snuyanzin force-pushed the shaded18 branch 2 times, most recently from 5c58d85 to 99fe5de Compare January 10, 2024 14:50
@snuyanzin
Copy link
Contributor Author

@flinkbot run azure

@snuyanzin snuyanzin marked this pull request as ready for review January 11, 2024 10:01
Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for driving this!

@snuyanzin
Copy link
Contributor Author

snuyanzin commented Jan 12, 2024

Thanks for having a look I will rebase to the latest branch and
split it in 2 commits: one for adopting jackson breaking change mentioned in description and another for the actual update. It should simplify code navigation in future

Oops splitting will not work since code for breaking change adoption requires already jackson 2.15.x..., so will keep in one commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants