Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-31650][metrics][rest][BP-1.17] Remove transient metrics for subtasks in terminal state #23988

Merged
merged 1 commit into from
Dec 26, 2023
Merged

[FLINK-31650][metrics][rest][BP-1.17] Remove transient metrics for subtasks in terminal state #23988

merged 1 commit into from
Dec 26, 2023

Conversation

X-czh
Copy link
Contributor

@X-czh X-czh commented Dec 25, 2023

What is the purpose of the change

Cherry picked from commit dd02828 (MR: #23447)

Brief change log

Removes transient metrics (idle/busy/backpressured time) for terminal subtasks in MetricStore.

Verifying this change

  • Added UT to test that the busy time metric is removed for terminal subtasks.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@X-czh
[FLINK-31650][metrics][rest] Remove transient metrics for subtasks in…
4b320c2 
… terminal state

This closes apache#23447

(cherry picked from commit dd02828)
@X-czh X-czh changed the title [FLINK-31650][metrics][rest] Remove transient metrics for subtasks in terminal state [FLINK-31650][metrics][rest][BP-1.17] Remove transient metrics for subtasks in terminal state Dec 25, 2023
@flinkbot
Copy link
Collaborator

flinkbot commented Dec 25, 2023 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@X-czh
Copy link
Contributor Author

X-czh commented Dec 25, 2023

@wanglijie95 Would you mind taking a look at the BP?

wanglijie95
wanglijie95 approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@wanglijie95 wanglijie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @X-czh .

@wanglijie95 wanglijie95 merged commit 024e970 into apache:release-1.17 Dec 26, 2023
@X-czh X-czh deleted the FLINK-31650-BP1.17 branch December 27, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanglijie95 wanglijie95 wanglijie95 approved these changes

Assignees
No one assigned
Labels
component=Runtime/Metrics component=Runtime/REST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@X-czh @flinkbot @wanglijie95