-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-34274][runtime] Implicitly disable resource wait timeout for A… #24238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change makes sense. I have a minor proposal that would allow not touching production code. PTAL
The CI failure is most likely due to FLINK-34200
...time/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerBuilder.java
Show resolved
Hide resolved
...time/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerBuilder.java
Show resolved
Hide resolved
Could we finalize this one? 🤔 |
I added the changes I proposed. That should be good enough from my end, if you're ok with those changes (just to bring the PR closer to being merged and resolving the test instability in |
I reverted those changes. See my responses above. The only thing I kept/added was removing the comment. I'm gonna rebase the branch to get a green CI (the e2e tests are failing due to FLINK-34420). |
…daptiveSchedulerTest.
…urceWaitTimeout anymore) and just adds confusion because we don't need to wait in this test: 0. The mentioned test method #testRequirementLowerBoundIncreaseBeyondCurrentParallelismAttemptsImmediateRescale does not exist (#testRequirementLowerBoundIncreaseBeyondCurrentParallelismKeepsJobRunning is most likely meant) 1. the startJobWithSlotsMatchingParallelism will be executed in the main thread and, therefore, finishes before updateJobResourceRequirements is triggered (which also runs in the main thread) 2. Running both calls in the main thread ensures sequential execution of the commands with the scheduler being in WaitingForResources state when calling updateJobResourceRequirements
…daptiveSchedulerTest (apache#24238)
https://issues.apache.org/jira/browse/FLINK-34274