Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34508][ci] Migrates S3 ITCases to Minio tests #24427

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

morazow
Copy link
Contributor

@morazow morazow commented Mar 1, 2024

What is the purpose of the change

Migrates S3 related ITCases and E2E tests to use Minio test container.

Brief change log

  • Removes S3TestCredentials class from S3 related integration tests
  • Adds MinioTestContainer to provide S3 credentials and filesystem initialization
  • Enable test container reuse for MinioTestContainer
  • Refactored JUnit4 from JUnit5 on changed classes
  • TODO: Removes S3 related environment (e.g, IT_CASE_S3_*) variables

Verifying this change

  • Azure CI pipelines should build successfully
  • GitHub Actions should build successfully

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no
    • The test files of S3 file system changes

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 1, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@morazow morazow marked this pull request as ready for review April 15, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants