Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34324][test] Makes all s3 related operations being declared and called in a single location #24463

Closed
wants to merge 4 commits into from

Conversation

XComp
Copy link
Contributor

@XComp XComp commented Mar 7, 2024

What is the purpose of the change

This PR contains some refactorings of the s3-related tests. I moved the branch from my fork (see related PR #24244) to the main repo to check whether this would enable the s3 related tests without merging the PR to master.

Brief change log

  • Fixes error message in test execution
  • unifies S3-related code in one location

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@XComp XComp changed the title Flink 34324 [FLINK-34324][test] Makes all s3 related operations being declared and called in a single location Mar 7, 2024
@flinkbot
Copy link
Collaborator

flinkbot commented Mar 7, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@XComp XComp closed this Mar 7, 2024
@XComp XComp deleted the FLINK-34324 branch March 7, 2024 13:40
@XComp
Copy link
Contributor Author

XComp commented Mar 7, 2024

I deleted the branch again because it doesn't enable the S3 credentials, of course. 🤦 Anyway, it's better to replace it with Minio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants