Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34571][test] Fix flaky test SortMergeResultPartitionReadSchedulerTest.testOnReadBufferRequestError #24469

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

reswqa
Copy link
Member

@reswqa reswqa commented Mar 8, 2024

What is the purpose of the change

We have a race condition in SortMergeResultPartitionReadSchedulerTest.testOnReadBufferRequestError, sometimes the reader finish reading before buffer pool destroyed.

Brief change log

  • Use a manually trigged executor to get rid of the race condition.

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

This actually fix a flaky test itself.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 8, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@WencongLiu WencongLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This code change ensures that the SortMergeResultPartitionReadScheduler will only request buffer after the BatchShuffleReadBufferPool is destoryed, which will trigger the handling failed logic and releaseSortMergeSubpartitionReader.

@reswqa
Copy link
Member Author

reswqa commented Mar 11, 2024

Thanks for the quick review!

@reswqa reswqa merged commit fcf61b9 into apache:master Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants