Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34988][build] Fix the reflection issue of ExecutionEnvironmentImpl for JDK17 #24610

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

reswqa
Copy link
Member

@reswqa reswqa commented Apr 3, 2024

What is the purpose of the change

In JDK17, we cannot access a final field via reflection by default. Following #22794, I have added --add-opens=java.base/java.util=ALL-UNNAMED to the module's pom.xml which including tests touch the ExecutionEnvironmentImpl.

Brief change log

  • added --add-opens=java.base/java.util=ALL-UNNAMED to the module's pom.xml which including tests touch the ExecutionEnvironmentImpl.

Verifying this change

Pull request CI is not run over JDK17, but I have tested all failed cases reported by FLINK-34988 in my local env(set JDK to 17).

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

Copy link
Contributor

@WencongLiu WencongLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The <surefire.module.config> property is correctly set to allow reflection on java.base/java.util in JDK 17 or higher, necessary for the DataStream V2 tests.

@reswqa
Copy link
Member Author

reswqa commented Apr 3, 2024

@flinkbot run azure

Copy link
Contributor

@RyanSkraba RyanSkraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 4, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@reswqa
Copy link
Member Author

reswqa commented Apr 4, 2024

@flinkbot run azure

@reswqa reswqa merged commit 54550e3 into apache:master Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants