[FLINK-35047][state] Shutdown StateExecutors when ForStKeyedStateBackend is closed

[ljz2051]

What is the purpose of the change

This pull request shuts down the ForStStateExecutors when ForStKeyedStateBackend is disposed.

Brief change log

• Shutdown the StateExecutors in ForStKeyedStateBackend.

Verifying this change

This change is already covered by existing tests, such as ForStStateBackendConfigTest and AsyncExecutionControllerTest.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no

[flinkbot]

CI report:

• 1f9e43a Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[jectpro7]

LGTM

[fredia]

Can this for-loop be placed outside the lock?

[ljz2051]

Based on the current implementation, it is indeed doable. However, I think that enclosing both disposed and managedStateExecutors within the protective scope of the lock constitutes a more safe practice. Additionally, the chance of a lock conflict between createStateExecutor() and dispose() is very minimal, so the impact in this place is virtually imperceptible.

So I prefer to put this for-loop of managedStateExecutors inside the lock scope.

WDYT?

[masteryhx]

Thanks for the PR, PTAL my comment.

[Zakelly]

I think we'd better note the shutdown contract down into the description/Javadoc of StateExecutor. The StateExecutor is managed by KeyedStateBackend and the AEC or operators won't take care of the lifecycle of it.

[ljz2051]

I think we'd better note the shutdown contract down into the description/Javadoc of StateExecutor. The StateExecutor is managed by KeyedStateBackend and the AEC or operators won't take care of the lifecycle of it.

@Zakelly Thanks for your suggestion. I have refined the JavaDoc in AsyncKeyedStateBackend#createStateExecutor and StateExecutor.

[Zakelly]

LGTM

[masteryhx]

Thanks for the update.
LGTM.