-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35359][config] General Improvement to Configuration for Flink 2.0 #24815
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sxnan
force-pushed
the
FLINK-35359
branch
4 times, most recently
from
May 22, 2024 01:13
e3be775
to
f80e6e0
Compare
xintongsong
reviewed
May 22, 2024
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
Outdated
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/configuration/ConfigurationUtils.java
Outdated
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/flink/runtime/taskmanager/NettyShuffleEnvironmentConfiguration.java
Outdated
Show resolved
Hide resolved
…ctory from user-defined class name There are no use internally to instantiate the BlockCompressionFactory from class name. Even though, it is possible for user to pass a user-defined class name to BlockCompressionFactory, this ability is never exposed in any public documentation.
@xintongsong Thanks for the review! I updated the PR accordingly. Please take another look. |
xintongsong
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
As Flink moves toward version 2.0, we want to provide users with a better experience with the existing configuration. In this PR, we make several improvements to the current configuration.
Brief change log
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: yesDocumentation