-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35533][runtime] Support Flink hybrid shuffle integration with Apache Celeborn #24900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red remote tier class
…ShuffleDescriptor
reswqa
changed the title
[Draft][FLINK-35533][runtime] Support Flink hybrid shuffle integration with Apache Celeborn
[FLINK-35533][runtime] Support Flink hybrid shuffle integration with Apache Celeborn
Jun 11, 2024
reswqa
reviewed
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, overall looks good. I only left a couple of comments.
flink-runtime/src/test/java/org/apache/flink/runtime/util/NettyShuffleDescriptorBuilder.java
Show resolved
Hide resolved
...he/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageConsumerClient.java
Outdated
Show resolved
Hide resolved
...he/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageConsumerClient.java
Outdated
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java
Outdated
Show resolved
Hide resolved
…orting remote tier plugin
TanYuxin-tyx
force-pushed
the
FLINK-35533
branch
from
June 12, 2024 06:03
0d350bd
to
2738bb5
Compare
reswqa
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TanYuxin-tyx for the update, LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Flink hybrid shuffle supports transitions between memory, disk, and remote storage to improve performance and job stability. Concurrently, Apache Celeborn provides a stable, performant, scalable remote shuffle service. This integration proposal is to harness the benefits from both hybrid shuffle and Celeborn simultaneously. This change is a pluggable remote tier implementation in Flink side.
Brief change log
Verifying this changeq
TierFactoryInitializerTest
that validates the creation of tier factoriesDoes this pull request potentially affect one of the following parts:
@Public(Evolving)
: (Yes)Documentation