-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35812][Core/API] Move tuple interfaces to flink-core-api #25074
Conversation
70a09e1
to
cf78e86
Compare
Rebased master.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we also move and change TupleGenerator
?
I suggest no. The I think we could achieve this when moving classes from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could achieve this when moving classes from org.apache.flink.core.fs to core-api module. WDYT?
Make sense, feel free to merge this % AZP green.
Thanks @reswqa , merging... |
What is the purpose of the change
This PR moves classes under package
org.apache.flink.api.java.tuple
fromflink-core
module toflink-core-api
.Brief change log
org.apache.flink.api.java.tuple
toflink-core-api
.org.apache.flink.types.NullFieldException
is also moved toflink-core-api
.StringUtils.arrayAwareToString
, but it is difficult to moveStringUtils
. So I copy the single function for tuple use.org.apache.flink.api.java.tuple.TupleGenerator
is left inflink-core
, since it depends on theorg.apache.flink.util.FileUtils
which is also difficult to move.Verifying this change
This change is a code cleanup and is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation