Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35812][Core/API] Move tuple interfaces to flink-core-api #25074

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

Zakelly
Copy link
Contributor

@Zakelly Zakelly commented Jul 11, 2024

What is the purpose of the change

This PR moves classes under package org.apache.flink.api.java.tuple from flink-core module to flink-core-api.

Brief change log

  • Move all classes under org.apache.flink.api.java.tuple to flink-core-api.
  • The depended org.apache.flink.types.NullFieldException is also moved to flink-core-api.
  • All the tuples depend on StringUtils.arrayAwareToString, but it is difficult to move StringUtils. So I copy the single function for tuple use.
  • Test org.apache.flink.api.java.tuple.TupleGenerator is left in flink-core, since it depends on the org.apache.flink.util.FileUtils which is also difficult to move.

Verifying this change

This change is a code cleanup and is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@Zakelly Zakelly requested a review from reswqa July 11, 2024 08:10
@flinkbot
Copy link
Collaborator

flinkbot commented Jul 11, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Zakelly
Copy link
Contributor Author

Zakelly commented Jul 15, 2024

Rebased master....

@reswqa reswqa self-assigned this Jul 16, 2024
Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we also move and change TupleGenerator?

@Zakelly
Copy link
Contributor Author

Zakelly commented Jul 16, 2024

TupleGenerator

I suggest no. The TupleGenerator depend heavily on org.apache.flink.util.FileUtils, which involves more dependencies under org.apache.flink.core.fs.*.

I think we could achieve this when moving classes from org.apache.flink.core.fs to core-api module. WDYT?

Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could achieve this when moving classes from org.apache.flink.core.fs to core-api module. WDYT?

Make sense, feel free to merge this % AZP green.

@Zakelly
Copy link
Contributor Author

Zakelly commented Jul 17, 2024

Thanks @reswqa , merging...

@Zakelly Zakelly merged commit 78c15a2 into apache:master Jul 17, 2024
@Zakelly Zakelly deleted the f35812 branch July 17, 2024 02:20
snuyanzin pushed a commit to snuyanzin/flink that referenced this pull request Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants