[FLINK-5175] StreamExecutionEnvironment's set function return this instead of void

[shijinkui]

StreamExecutionEnvironment's set function return this instead of void

for example :

public void setNumberOfExecutionRetries(int numberOfExecutionRetries) {
config.setNumberOfExecutionRetries(numberOfExecutionRetries);
}

change to:

public StreamExecutionEnvironment setNumberOfExecutionRetries(int numberOfExecutionRetries) {
config.setNumberOfExecutionRetries(numberOfExecutionRetries);
return this;
}

• General

  • The pull request references the related JIRA issue ("[FLINK-5175] StreamExecutionEnvironment's set function return this instead of void")
  • The pull request addresses only one issue
  • Each commit in the PR has a meaningful commit message (including the JIRA id)

• Documentation

  • Documentation has been added for new functionality
  • Old documentation affected by the pull request has been updated
  • JavaDoc for public methods has been added

• Tests & Build

  • Functionality added by the pull request is covered by tests
  • mvn clean verify has been executed successfully locally or a Travis build has passed

[fhueske]

The PR changes several @Public and @PublicEvolving methods.

We do not touch @public interfaces for 1.x releases and also try to avoid to modify @PublicEvolving interface except for very good reasons. We have a Maven plugin that prevents changes that break the binary compatibility of methods and classes annotated with @Public.
By building the code before opening a pull request, you can early detect such issues.

I don't think that we can and should merge this PR.

[shijinkui]

The PR changes several @public and @PublicEvolving methods.

hi, @fhueske
Today when set some config, find some function cant't chained one by one. So want to complete all the function needed return this conveniently. If chained setting config, the setting will be together, avoid setting config everywhere.

It's only better used, not important. You can close this.

[fhueske]

Thanks for the proposal @shijinkui. I agree that the changes might improve the usability a bit for some users. However, the improvements are not significant enough to break the API, IMO.

I'll close this PR and the issue.
Thanks, Fabian

[StephanEwen]

@shijinkui I think these changes would be great for Flink 2.0

Can you add them to this list here? That is where we collect all API-.breaking changes that we want to add.
https://issues.apache.org/jira/browse/FLINK-3957

Thanks!

[shijinkui]

Can you add them to this list here? That is where we collect all API-.breaking changes that we want to add.

Done.