[FLINK-6882] [runtime] Activate checkstyle for runtime/registration #4099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greghogan
force-pushed
the
6882_activate_checkstyle_for_runtime_registration
branch
from
9845563
to
ad79843
Compare
|
@zentol not sure if this was overlooked. I have rebased to master, is there anyone you think we should check with before including this package? |
|
I wasn't quite sure about this one; I had a chat with @tillrohrmann and he suggested to bec areful in this package. But the changes aren't that substantial, so I would say +1 to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.