[FLINK-8571] [DataStream] [Backport] Introduce utility function that reinterprets a data stream as keyed stream #5439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s a data stream as keyed stream (backport from 1.5 branch)
tzulitai
approved these changes
Feb 9, 2018
tzulitai
reviewed
Feb 9, 2018
| public TemporaryFolder temporaryFolder = new TemporaryFolder(); | ||
|
|
||
| /** | ||
| * FLINK-8571 |
There was a problem hiding this comment.
Can maybe remove this? I think there isn't a need to explicitly tag this.
There was a problem hiding this comment.
@StefanRRichter Yes, this can then probably also be removed from the original PR before merging.
|
The changes look good! But as @tzulitai mentioned the missing Scala tests seem strange. |
|
Added the test. |
|
LGTM once Travis is green. |
|
Thanks for the reviews! Will merge. |
asfgit
pushed a commit
that referenced
this pull request
Feb 9, 2018
…s a data stream as keyed stream (backport from 1.5 branch) This closes #5439.
JTaky
pushed a commit
to criteo-forks/flink
that referenced
this pull request
Feb 16, 2018
…s a data stream as keyed stream (backport from 1.5 branch) This closes apache#5439.
glaksh100
pushed a commit
to lyft/flink
that referenced
this pull request
Jun 6, 2018
…s a data stream as keyed stream (backport from 1.5 branch) This closes apache#5439.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a backport of #5424 to Flink 1.4.