Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-9293] [runtime] SlotPool should check slot id when accepting a slot offer with existing allocation id #5951

Closed
wants to merge 1 commit into from

Conversation

shuai-xu
Copy link
Contributor

@shuai-xu shuai-xu commented May 3, 2018

What is the purpose of the change

This pull request fix that job master will accept multi slot offers with same allocation id and make the later slots leak.

Verifying this change

This change added tests and can be verified as follows:

(example:)

  • Run the SlotPoolTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@StephanEwen
Copy link
Contributor

Good catch! Thank you for the PR.

Will try to review this asap...

StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request May 3, 2018
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request May 3, 2018
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request May 3, 2018
@asfgit asfgit closed this in bbaf82e May 3, 2018
sampathBhat pushed a commit to sampathBhat/flink that referenced this pull request Jul 26, 2018
… slot offer with existing allocation id

This closes apache#5951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants