Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-8558] [table] Add unified format interfaces and separate formats from connectors #6264

Closed
wants to merge 8 commits into from
Closed

[FLINK-8558] [table] Add unified format interfaces and separate formats from connectors #6264

wants to merge 8 commits into from

Commits on Jul 5, 2018

  1. [FLINK-8558] [table] Add unified format interfaces and separate forma… 

    …ts from connectors

This PR introduces a format discovery mechanism based on Java Service Providers. The general `TableFormatFactory` is similar to the existing table source discovery mechanism. However, it allows for arbirary format interfaces that might be introduced in the future. At the moment, a connector can request configured instances of `DeserializationSchema` and `SerializationSchema`. In the future we can add interfaces such as a `Writer` or `KeyedSerializationSchema` without breaking backwards compatibility.

This PR deprecates the existing strong coupling of connector and format for the Kafa table sources and table source factories. It introduces descriptor-based alternatives.
    @twalthr
    twalthr committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    9415066 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2018

  1. Feedback addressed

    @twalthr
    twalthr committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    c186701 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2018

  1. Introduce more constants

    @twalthr
    twalthr committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    f7dd475 View commit details
    Browse the repository at this point in the history

  2. Add proper null check for format factory

    @twalthr
    twalthr committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    e117987 View commit details
    Browse the repository at this point in the history

  3. Extract methods

    @twalthr
    twalthr committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    9649c38 View commit details
    Browse the repository at this point in the history

  4. Remove nulls in format factory service

    @twalthr
    twalthr committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    1931689 View commit details
    Browse the repository at this point in the history

  5. Improve format factory tests

    @twalthr
    twalthr committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    3cbaa8d View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2018

  1. Remove nullable again

    @twalthr
    twalthr committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    9400511 View commit details
    Browse the repository at this point in the history