[FLINK-11073] [core] Allow immutable serializers #7239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypeSerializerSchemaCompatibility
The CompositeTypeSerializerSnapshot encapsulates logic for handling writing, reading, and deriving final compatibility results for composite serializers that have multiple nested serializers.
…erializerSnapshot
…mpositeTypeSerializerSnapshot
…SerializerSnapshot
…peSerializerSnapshot
…eTypeSerializerSnapshot
…eSerializerSnapshot
…TypeSerializerSnapshot
…alizersSnapshotDelegate After introducing CompositeTypeSerializerSnapshot, the CompositeSerializerSnapshot has been reworked to only deal with concerns of delegating reading and writing of the nested serializers' snapshots. It no longer deals with resolving the final compatibility result for the outer composite serializer. Therefore, it is renamed properly as NestedSerializersSnapshotDelegate, and also annotated as an internal class, since we want users to use the more powerful CompositeTypeSerializerSnapshot instead.
…iteTypeSerializerSnapshot
…t, not restore serializers
…ot class in TypeSerializerSnapshotMigrationTestBase This strengthens the test base to make use of the provided snapshot class in the test specifications, to assert that serializers are really using the expected classes for their current serializer snapshots.
…SerializerSnapshot
|
This PR is now subsumed by #7422. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
See JIRA FLINK-11073 for a detailed description of the motivation for this PR.
Brief change log
TypeSerializerSchemaCompatibility.compatibleWithReconfiguredSerializer(TypeSerializer)as a new option for compatibility result checks.CompositeTypeSerializerSnapshotclass. This encapsulates logic for handlingwriting, reading, and deriving final compatibility results for composite
serializers that have multiple nested serializers. It also respects the new
TypeSerializerSchemaCompatibility.compatibleWithReconfiguredSerializer(TypeSerializer)case.CompositeSerializerSnapshotclass to extendthe new
CompositeTypeSerializerSnapshot.CompositeSerializerSnapshottoNestedSerializersSnapshotDelegateto better convey its purpose after the rework. The class is also now annotated as final, as users should be using theCompositeTypeSerializerSnapshotclass instead.Verifying this change
All corresponding
XXSerializerSnapshotMigrationTestof the touched serializer snapshots should all still be passing.Does this pull request potentially affect one of the following parts:
This does affect one
PublicEvolvingAPI, theCompositeSerializerSnapshot.It has been renamed and now made
Internal.@Public(Evolving): (yes / no)