[FLINK-11181][tests] Fix SimpleRecoveryFailureRateStrategyITBase test error #7316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for the PR @hequn8128
I only left one suggestion.
Bests,
Jincheng
| @@ -59,7 +60,7 @@ public void testFailedRunThenSuccessfulRun() throws Exception { | |||
|
|
|||
| env.generateSequence(1, 10) | |||
| .rebalance() | |||
| .map(new FailingMapper1<Long>()) | |||
There was a problem hiding this comment.
Add finally reset will work well.
finally {
FailingMapper1.failuresBeforeSuccess = 1;
}
|
@sunjincheng121 Thanks a lot for your review and suggestions. I have updated the code. Best, Hequn |
|
Thanks for the quick update！ @hequn8128 Thanks, Jincheng |
sunjincheng121
pushed a commit
to sunjincheng121/flink
that referenced
this pull request
Jan 3, 2019
… error This colses apache#7316
tisonkun
pushed a commit
to tisonkun/flink
that referenced
this pull request
Jan 17, 2019
… error This colses apache#7316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request fix
SimpleRecoveryFailureRateStrategyITBasetest error.The configuration has not been passed to the
MiniClusterWithClientResource.Brief change log
MiniClusterWithClientResource.Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation