Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-14241][test] Add aarch64 support for container e2e test #9782

Closed

Conversation

wangxiyuan
Copy link
Contributor

What is the purpose of the change

Flink e2e container test runs under docker, docker-compose and kubernets. But the way Flink using to install the package doesn't work on ARM. This PR add the ARM way to install the required tools.

Brief change log

  • Add the ARM step to install Docker and Docker-compose
  • Add the ARM step to install kubernetes.

Verifying this change

This change is already covered by existing tests, such as flink-end-to-end container test.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 27, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 255fb34 (Wed Apr 15 11:38:40 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 27, 2019

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@wangxiyuan wangxiyuan force-pushed the support_arm_docker_compose branch 3 times, most recently from c568fa4 to aa2b0e8 Compare October 11, 2019 02:01
@wangxiyuan wangxiyuan force-pushed the support_arm_docker_compose branch 4 times, most recently from 938ebf9 to 8c72f98 Compare December 3, 2019 03:44
@wangxiyuan wangxiyuan changed the title [FLINK-14241][test] Add ARM installation steps for flink e2e container tests [FLINK-14241][test] Add aarch64 support for container e2e test Dec 5, 2019
@wangxiyuan wangxiyuan force-pushed the support_arm_docker_compose branch 2 times, most recently from 0739a62 to 515f012 Compare December 23, 2019 01:30
@wangxiyuan wangxiyuan force-pushed the support_arm_docker_compose branch 2 times, most recently from f527034 to d8fa507 Compare January 21, 2020 01:54
@StephanEwen
Copy link
Contributor

Looks good from my side.

@zentol or @rmetzger do you have any concerns with the script updates?

@rmetzger
Copy link
Contributor

I'm okay with merging this as proposed (the commit message is not correct yet). I would still feel more comfortable if we had @zentol's +1 as well.

@wangxiyuan
Copy link
Contributor Author

Thanks for your review. Just fixed the merge conflic. @zentol can you take a look? Thank you.

@wangxiyuan wangxiyuan force-pushed the support_arm_docker_compose branch 2 times, most recently from f2415e3 to 255fb34 Compare April 1, 2020 09:08
@wangxiyuan
Copy link
Contributor Author

any chance that this PR can be reviewed again? Thanks

Docker-compose doesn't have arm release bin file. Use pip3 install
for arm arch
Copy link
Contributor

@rmetzger rmetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. This change is +1 to merge once Azure's E2E run is green

@rmetzger rmetzger closed this in 9bef952 Apr 30, 2020
@wangxiyuan wangxiyuan deleted the support_arm_docker_compose branch May 6, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants