-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-14241][test] Add aarch64 support for container e2e test #9782
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 255fb34 (Wed Apr 15 11:38:40 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
d48b955
to
bc7ff38
Compare
c568fa4
to
aa2b0e8
Compare
938ebf9
to
8c72f98
Compare
0739a62
to
515f012
Compare
515f012
to
408305b
Compare
f527034
to
d8fa507
Compare
I'm okay with merging this as proposed (the commit message is not correct yet). I would still feel more comfortable if we had @zentol's +1 as well. |
d8fa507
to
e60d531
Compare
Thanks for your review. Just fixed the merge conflic. @zentol can you take a look? Thank you. |
e60d531
to
2c3fb6f
Compare
f2415e3
to
255fb34
Compare
255fb34
to
fda598e
Compare
any chance that this PR can be reviewed again? Thanks |
fda598e
to
1b3b95c
Compare
Docker-compose doesn't have arm release bin file. Use pip3 install for arm arch
1b3b95c
to
0f20a79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. This change is +1 to merge once Azure's E2E run is green
What is the purpose of the change
Flink e2e container test runs under docker, docker-compose and kubernets. But the way Flink using to install the package doesn't work on ARM. This PR add the ARM way to install the required tools.
Brief change log
Verifying this change
This change is already covered by existing tests, such as flink-end-to-end container test.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation