fixes #867 - Stream support for Scanners #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-turner
requested changes
Jul 21, 2017
| this.age = a; | ||
| this.id = id; | ||
| } | ||
|
|
There was a problem hiding this comment.
Since these are being placed in a set, also need to implement equals method.
| expected.add(new Person("Hulk", "Hogan", 60, 55234234)); | ||
|
|
||
| Assert.assertEquals(expected.hashCode(), people.hashCode()); | ||
| Assert.assertEquals(expected.size(), people.size()); |
There was a problem hiding this comment.
After adding a equals method to the Person type , you can replace these two checks with :
Assert.assertEquals(expected, people);
| colsVal.add(new ColumnValue(new Column("f1", "q2"), Bytes.of("v4"))); | ||
| colsVal.add(new ColumnValue(new Column("f2", "q5"), Bytes.of("v5"))); | ||
|
|
||
| ColumnScanner colScanStream = new ColumnScannerImpl(row, colsVal); |
There was a problem hiding this comment.
Personally I would not have Stream in this var name. Could call it scanner of colScanner
| rowCols.stream().filter(rcv -> rcv.getColumn().getsFamily().equals("f2")) | ||
| .collect(Collectors.toSet()); | ||
| cellScanStream.stream().filter(rcv -> rcv.getColumn().getsFamily().equals("f2")) | ||
| .collect(Collectors.toSet()); |
There was a problem hiding this comment.
Nothing is done with the sets created by the two stream operations above.
keith-turner
approved these changes
Jul 24, 2017
mikewalch
approved these changes
Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.