Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Rust): Refine Code Structure & Prepare for Future Compatibility Features #1787

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

theweipeng
Copy link
Member

What does this PR do?

  1. Split the serializers from one file to individual files.
  2. Merged FuryMeta, Serialize, and Deserialize traits into the Serializer trait; it is no longer necessary to keep them separate.
  3. Implemented Type Meta for use in compatibility features in the next PR.
  4. Added an individual trait FuryGeneralList to distinguish between general Vec and PrimitiveArray in the Fury protocol. Currently, having write_vec and read_vec in the Serialize trait is unconventional.

Related issues

Does this PR introduce any user-facing change?

This PR introduces a user-facing change. Previously, we used from_buffer and to_buffer to serialize and deserialize objects.
Now, we should create an instance of Fury and call the methods from_buffer and to_buffer to process objects.

@theweipeng theweipeng changed the title [Rust] Optimize the code structure [Rust] Refine Code Structure & Prepare for Future Compatibility Features Aug 2, 2024
@theweipeng theweipeng changed the title [Rust] Refine Code Structure & Prepare for Future Compatibility Features feat[Rust] Refine Code Structure & Prepare for Future Compatibility Features Aug 2, 2024
@theweipeng theweipeng changed the title feat[Rust] Refine Code Structure & Prepare for Future Compatibility Features feat(Rust) Refine Code Structure & Prepare for Future Compatibility Features Aug 2, 2024
@theweipeng theweipeng changed the title feat(Rust) Refine Code Structure & Prepare for Future Compatibility Features feat(Rust): Refine Code Structure & Prepare for Future Compatibility Features Aug 2, 2024
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, But could we rename from_buffer/to_buffer to serialize/deserialize in future?

@theweipeng
Copy link
Member Author

LGTM, But could we rename from_buffer/to_buffer to serialize/deserialize in future?

I have already renamed them in this PR

@theweipeng theweipeng merged commit fb34adf into apache:main Aug 2, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants