Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): use iter to avoid reallocate #1821

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

jiacai2050
Copy link
Contributor

What does this PR do?

Use iterator + collect to avoid re-allocate vec/set/map.

Related issues

Does this PR introduce any user-facing change?

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

@jiacai2050 jiacai2050 changed the title fix: use iter to avoid reallocate fix(rust): use iter to avoid reallocate Aug 29, 2024
Copy link
Member

@theweipeng theweipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theweipeng theweipeng merged commit 0af2084 into apache:main Aug 29, 2024
35 checks passed
@jiacai2050 jiacai2050 deleted the fix-avoid-realloc branch August 29, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants