Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-4864 Document the gfsh create jndi-binding command #1644

Merged

Conversation

karensmolermiller
Copy link
Contributor

No description provided.

| Name | Description | Default |
|----------------------------------------------------|----------------------------------------------------------------------------------------|---------|
| <span class="keyword parmname">\\-\\-name</span> | *Required.* Name of the binding to create. |   |
| <span class="keyword parmname">\\-\\-type</span> | *Required.* Type of the XA datasource. One of: MANAGED, SIMPLE, POOLED, or XAPOOLED. |   |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put these types in code font: 'MANAGED', 'SIMPLE', 'POOLED', or 'XAPOOLED'.

Copy link
Member

@sboorlagadda sboorlagadda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the requested change.

- **[create jndi-binding](#create_jndi-binding)**

Create a JNDI binding that specifies a resource accessed with
a JDBC connection.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the wording as in "Create a JNDI binding that specifies resource attributes which describe a JDBC connection."

@karensmolermiller karensmolermiller merged commit 05feafb into apache:develop Mar 20, 2018
@karensmolermiller karensmolermiller deleted the feature/GEODE-4864 branch March 20, 2018 00:29
Copy link
Contributor

@davebarnes97 davebarnes97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants