GEODE-7590 - Use GCESysprep as last-step in Windows Packer build. #4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix instance cleanup per zone. * delete_instanch.sh deletes in all zones just in case. * Ask for zones, don't assume. * Use Packer release 1.4.5, not latest prerelease. * Need reboot before running GCESysPrep in case of windows update.
rhoughton-pivot
requested review from
smgoller,
jdeppe-pivotal and
onichols-pivotal
onichols-pivotal
approved these changes
Dec 24, 2019
jake-at-work
approved these changes
Dec 24, 2019
|
When merged, we need to unpause all the jobs. |
|
All the Windows jobs have been unpaused and verdant since Friday... |
|
Because I deleted the version of the windows image with the updated
GCEWindowsAgent
…On Mon, Dec 23, 2019, 22:17 Owen Nichols ***@***.***> wrote:
All the Windows jobs have been unpaused and verdant since Friday...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4522?email_source=notifications&email_token=AHVPPUW4MCKZCUSQUODNACTQ2GSQDA5CNFSM4J6ZG4AKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHSSSJY#issuecomment-568666407>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHVPPUSAV7XYYHFX2RKMLO3Q2GSQDANCNFSM4J6ZG4AA>
.
|
davebarnes97
pushed a commit
to davebarnes97/geode
that referenced
this pull request
Jan 22, 2020
…ache#4522) * Fix instance cleanup per zone. * delete_instanch.sh deletes in all zones just in case. * Ask for zones, don't assume. * Use Packer release 1.4.5, not latest prerelease. * Need reboot before running GCESysPrep in case of windows update.
mhansonp
pushed a commit
to mhansonp/geode
that referenced
this pull request
Mar 12, 2020
…ache#4522) * Fix instance cleanup per zone. * delete_instanch.sh deletes in all zones just in case. * Ask for zones, don't assume. * Use Packer release 1.4.5, not latest prerelease. * Need reboot before running GCESysPrep in case of windows update.
kirklund
pushed a commit
to kirklund/geode
that referenced
this pull request
Jul 9, 2020
…ache#4522) * Fix instance cleanup per zone. * delete_instanch.sh deletes in all zones just in case. * Ask for zones, don't assume. * Use Packer release 1.4.5, not latest prerelease. * Need reboot before running GCESysPrep in case of windows update. (cherry picked from commit 2178ba8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?[n/a] Have you written or updated unit tests to verify your changes?
[n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.