Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GOBBLIN-573: Add option to use finer level granularity at the hour level for TimeAwareDatasetfinder #2438

Closed
wants to merge 7 commits into from
Closed

GOBBLIN-573: Add option to use finer level granularity at the hour level for TimeAwareDatasetfinder #2438

wants to merge 7 commits into from

Conversation

sv2000
Copy link
Contributor

@sv2000 sv2000 commented Aug 30, 2018

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Add option to use finer level granularity at the hour level for TimeAwareDatasetfinder.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Added unit test TimeAwareRecursiveCopyableDatasetTest.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@sv2000
Copy link
Contributor Author

sv2000 commented Aug 30, 2018

@htran1 Please review.

htran1
htran1 suggested changes Aug 30, 2018
View reviewed changes
...src/main/java/org/apache/gobblin/data/management/copy/TimeAwareRecursiveCopyableDataset.java Outdated
LocalDateTime startDate = endDate.minusDays(lookbackDays);
LocalDateTime startDate;
if (this.lookbackTime.endsWith("d")) {
startDate = endDate.minusDays(Long.parseLong(lookbackTime.substring(0, lookbackTime.length() - 1)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using Period like in SelectBetweenTimeBasedPolicy? I think that allows mixing like 7d6h.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion! Thanks!

htran1
htran1 approved these changes Aug 31, 2018
View reviewed changes
Copy link
Contributor

@htran1 htran1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit closed this in ef438c8 Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htran1 htran1 htran1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sv2000 @htran1