Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GORA-478 Address Sonar issues within gora-accumulo Encoder classes #68

Merged
merged 4 commits into from
May 26, 2016

Conversation

lewismc
Copy link
Member

@lewismc lewismc commented May 26, 2016

This issue addresses https://issues.apache.org/jira/browse/GORA-478
It

  • uses the @OverRide notation where appropriate
  • uses try-with-resources notation to greatly reduce the amount of incorrect exception handling, steam closing and encoder closing, this has the knock on issue of better Encoder APi design where Exceptions are included and enforced as part of the Encoder interface
  • implements very trivial safety improvements such as moving array declarations from variables to types, and uppercasing 'l' to 'L' for long values.

@renato2099
Copy link
Contributor

👍 Thanks @lewismc !

@asfgit asfgit merged commit da10306 into apache:master May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants