Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched Accumulo Dependency to 1.7.1 and ported AccumuloStore Class to work with accumulo 1.7.1 #97

Merged
merged 3 commits into from
Feb 22, 2017

Conversation

vaibhavthapliyal
Copy link
Contributor

No description provided.

@lewismc
Copy link
Member

lewismc commented Feb 17, 2017

@vaibhavthapliyal thank you for this, can you please format the code in 2 space indents? Thank you.

# Conflicts:
#	gora-accumulo/src/main/java/org/apache/gora/accumulo/store/AccumuloStore.java
@vaibhavthapliyal
Copy link
Contributor Author

@lewismc Can you check it now, if it's formatted correctly?

@lewismc
Copy link
Member

lewismc commented Feb 21, 2017

Yes this looks much better. I'll try and review shortly.

@vaibhavthapliyal
Copy link
Contributor Author

Thanks. Will be looking forward to hearing from you.

@lewismc
Copy link
Member

lewismc commented Feb 22, 2017

Hi @vaibhavthapliyal when I run the test suite, I get the following

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.gora.accumulo.store.AccumuloStoreTest
2017-02-21 20:15:03,855 INFO  [main] store.DataStoreTestBase (DataStoreTestBase.java:setUpClass(67)) - setting up class
2017-02-21 20:15:03,857 INFO  [main] gora.GoraTestDriver (GoraAccumuloTestDriver.java:setUpClass(50)) - Starting Accumulo MiniAccumuloCluster...
2017-02-21 20:15:07,283 INFO  [main] impl.MiniAccumuloClusterImpl (MiniAccumuloClusterImpl.java:start(609)) - Starting MAC against instance goraTest and zookeeper(s) localhost:56321.
2017-02-21 20:15:09,847 INFO  [main] store.DataStoreTestBase (DataStoreTestBase.java:setUp(90)) - setting up test
2017-02-21 20:15:10,671 WARN  [main] client.ClientConfiguration (ClientConfiguration.java:loadFromSearchPath(227)) - Found no client.conf in default paths. Using default client configuration values.
2017-02-21 20:15:10,754 INFO  [main] zookeeper.ZooKeeper (Environment.java:logEnv(100)) - Client environment:zookeeper.version=3.4.5-1392090, built on 09/30/2012 17:52 GMT
2017-02-21 20:15:10,755 INFO  [main] zookeeper.ZooKeeper (Environment.java:logEnv(100)) - Client environment:host.name=lmc-056430
2017-02-21 20:15:10,755 INFO  [main] zookeeper.ZooKeeper (Environment.java:logEnv(100)) - Client environment:java.version=1.8.0_91
2017-02-21 20:15:10,756 INFO  [main] zookeeper.ZooKeeper (Environment.java:logEnv(100)) - Client environment:java.vendor=Oracle Corporation
2017-02-21 20:15:10,756 INFO  [main] zookeeper.ZooKeeper (Environment.java:logEnv(100)) - Client environment:java.home=/Library/Java/JavaVirtualMachines/jdk1.8.0_91.jdk/Contents/Home/jre
2017-02-21 20:15:10,757 INFO  [main] zookeeper.ZooKeeper (Environment.java:logEnv(100)) - Client environment:java.class.path=/usr/local/gora/gora-accumulo/target/test-classes:/usr/local/gora/gora-accumulo/target/classes
...
/Users/lmcgibbn/.m2/repository/org/apache/hadoop/hadoop-mapreduce-client-hs/2.5.2/hadoop-mapreduce-client-hs-2.5.2.jar:
2017-02-21 20:15:10,759 INFO  [main] zookeeper.ZooKeeper (Environment.java:logEnv(100)) - Client environment:java.library.path=/Users/lmcgibbn/Library/Java/Extensions:/Library/Java/Extensions:/Network/Library/Java/Extensions:/System/Library/Java/Extensions:/usr/lib/java:.
2017-02-21 20:15:10,760 INFO  [main] zookeeper.ZooKeeper (Environment.java:logEnv(100)) - Client environment:java.io.tmpdir=/var/folders/mw/f_p4r21n5ld16hnyd7j8r8w4fv8362/T/
2017-02-21 20:15:10,760 INFO  [main] zookeeper.ZooKeeper (Environment.java:logEnv(100)) - Client environment:java.compiler=<NA>
2017-02-21 20:15:10,760 INFO  [main] zookeeper.ZooKeeper (Environment.java:logEnv(100)) - Client environment:os.name=Mac OS X
2017-02-21 20:15:10,761 INFO  [main] zookeeper.ZooKeeper (Environment.java:logEnv(100)) - Client environment:os.arch=x86_64
2017-02-21 20:15:10,763 INFO  [main] zookeeper.ZooKeeper (Environment.java:logEnv(100)) - Client environment:os.version=10.11.6
2017-02-21 20:15:10,764 INFO  [main] zookeeper.ZooKeeper (Environment.java:logEnv(100)) - Client environment:user.name=lmcgibbn
2017-02-21 20:15:10,764 INFO  [main] zookeeper.ZooKeeper (Environment.java:logEnv(100)) - Client environment:user.home=/Users/lmcgibbn
2017-02-21 20:15:10,764 INFO  [main] zookeeper.ZooKeeper (Environment.java:logEnv(100)) - Client environment:user.dir=/usr/local/gora/gora-accumulo
2017-02-21 20:15:10,765 INFO  [main] zookeeper.ZooKeeper (ZooKeeper.java:<init>(438)) - Initiating client connection, connectString=localhost:56321 sessionTimeout=30000 watcher=org.apache.accumulo.fate.zookeeper.ZooSession$ZooWatcher@4009e306
2017-02-21 20:15:10,798 INFO  [main-SendThread(localhost:56321)] zookeeper.ClientCnxn (ClientCnxn.java:logStartConnect(966)) - Opening socket connection to server localhost/0:0:0:0:0:0:0:1:56321. Will not attempt to authenticate using SASL (unknown error)
2017-02-21 20:15:10,821 WARN  [main-SendThread(localhost:56321)] zookeeper.ClientCnxn (ClientCnxn.java:run(1089)) - Session 0x0 for server null, unexpected error, closing socket connection and attempting reconnect
java.net.ConnectException: Connection refused
	at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
	at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
	at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:350)
	at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1068)
2017-02-21 20:15:10,930 INFO  [main-SendThread(localhost:56321)] zookeeper.ClientCnxn (ClientCnxn.java:logStartConnect(966)) - Opening socket connection to server localhost/127.0.0.1:56321. Will not attempt to authenticate using SASL (unknown error)
2017-02-21 20:15:10,933 INFO  [main-SendThread(localhost:56321)] zookeeper.ClientCnxn (ClientCnxn.java:primeConnection(849)) - Socket connection established to localhost/127.0.0.1:56321, initiating session
2017-02-21 20:15:10,944 INFO  [main-SendThread(localhost:56321)] zookeeper.ClientCnxn (ClientCnxn.java:onConnected(1207)) - Session establishment complete on server localhost/127.0.0.1:56321, sessionid = 0x15a64079dd40004, negotiated timeout = 30000
2017-02-21 20:17:13,269 WARN  [Thrift Connection Pool Checker] impl.ThriftTransportPool (ThriftTransportPool.java:checkForStuckIO(206)) - Thread "main" stuck on IO to LMC-056430:54933 (0) for at least 120171 ms

Tests then hang. I found some existing issues similar to this, I'm seeing if I can debug and get further with this.
I did notice that we don't use a client.conf, this may be something we need to implement in the Driver setup or via client.conf. Not sure yet.

@lewismc
Copy link
Member

lewismc commented Feb 22, 2017

I also created https://issues.apache.org/jira/browse/GORA-504 to track the issue

@vaibhavthapliyal
Copy link
Contributor Author

Hi,
Do the tests proceed further in your case after this line?
2017-02-21 20:17:13,269 WARN [Thrift Connection Pool Checker] impl.ThriftTransportPool (ThriftTransportPool.java:checkForStuckIO(206)) - Thread "main" stuck on IO to LMC-056430:54933 (0) for at least 120171 ms

I get a build sucess even after the Connection Refused. I'll check for some fixes and revert back.

@lewismc
Copy link
Member

lewismc commented Feb 22, 2017

Do the tests proceed further in your case after this line?

No they stall... can someone else check for tests continuing and passing with this patch?

@renato2099 can you please check?

@vaibhavthapliyal
Copy link
Contributor Author

vaibhavthapliyal commented Feb 22, 2017

@lewismc Hi, I think the issue is with your /etc/hosts file.

Make sure you have these entries in your host file.
127.0.0.1 localhost
127.0.0.1 your_hostname
Can you please check if this fixes the issue?
A reference to the solution of this can be found here:
https://community.cloudera.com/t5/Storage-Random-Access-HDFS/Problems-running-a-write-query-on-an-accumulo-cluster/td-p/21786/page/2

@renato2099
Copy link
Contributor

@vaibhavthapliyal @lewismc I applied the PR and gora-accumulo passed all tests successfully 👍

@renato2099
Copy link
Contributor

@lewismc regarding the 2space vs 4space, the only issue with this is that now the whole AccumuloStore looks like if it was modified, didn't we had a style check on maven at some point? maybe we should have a JIRA to just make the whole code standard and keep the changes of this PR only addressing the ones that it's supposed to

@lewismc
Copy link
Member

lewismc commented Feb 22, 2017 via email

@asfgit asfgit merged commit 4bbf52e into apache:master Feb 22, 2017
@lewismc
Copy link
Member

lewismc commented Feb 22, 2017

I adjusted my /etc/hosts file and all is good, thank you @vaibhavthapliyal

@vaibhavthapliyal
Copy link
Contributor Author

Cheers!

@renato2099
Copy link
Contributor

thanks @vaibhavthapliyal !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants