-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched Accumulo Dependency to 1.7.1 and ported AccumuloStore Class to work with accumulo 1.7.1 #97
Conversation
work with accumulo 1.7.1
@vaibhavthapliyal thank you for this, can you please format the code in 2 space indents? Thank you. |
# Conflicts: # gora-accumulo/src/main/java/org/apache/gora/accumulo/store/AccumuloStore.java
@lewismc Can you check it now, if it's formatted correctly? |
Yes this looks much better. I'll try and review shortly. |
Thanks. Will be looking forward to hearing from you. |
Hi @vaibhavthapliyal when I run the test suite, I get the following
Tests then hang. I found some existing issues similar to this, I'm seeing if I can debug and get further with this. |
I also created https://issues.apache.org/jira/browse/GORA-504 to track the issue |
Hi, I get a build sucess even after the Connection Refused. I'll check for some fixes and revert back. |
No they stall... can someone else check for tests continuing and passing with this patch? @renato2099 can you please check? |
@lewismc Hi, I think the issue is with your /etc/hosts file. Make sure you have these entries in your host file. |
@vaibhavthapliyal @lewismc I applied the PR and gora-accumulo passed all tests successfully 👍 |
@lewismc regarding the 2space vs 4space, the only issue with this is that now the whole AccumuloStore looks like if it was modified, didn't we had a style check on maven at some point? maybe we should have a JIRA to just make the whole code standard and keep the changes of this PR only addressing the ones that it's supposed to |
Regarding the formatting... yeah I agree. That's my fault, I thought
AccumuloStore was already formatted 2 space indents.
We should probably use the maven formatting plugin with out code template
in a subsequent issue.
On Wed, Feb 22, 2017 at 4:53 AM Renato Marroquin ***@***.***> wrote:
@lewismc <https://github.com/lewismc> regarding the 2space vs 4space, the
only issue with this is that now the whole AccumuloStore looks like if it
was modified, didn't we had a style check on maven at some point? maybe we
should have a JIRA to just make the whole code standard and keep the
changes of this PR only addressing the ones that it's supposed to
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#97 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABHJl1EHr9v5PUkq3mjn0w2XA8nIqeg8ks5rfC_kgaJpZM4MEAkC>
.
--
*Lewis*
Dr. Lewis J. McGibbney Ph.D, B.Sc
Director, MCMA Associates
Phone: +1(626)498-3090
Skype: lewis.john.mcgibbney
Email: lewis.mcgibbney@gmail.com
|
I adjusted my /etc/hosts file and all is good, thank you @vaibhavthapliyal |
Cheers! |
thanks @vaibhavthapliyal ! |
No description provided.