Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Package gravitino trino-connector package #542

Closed
jerryshao opened this issue Oct 18, 2023 · 2 comments · Fixed by #578
Closed

[Improvement] Package gravitino trino-connector package #542

jerryshao opened this issue Oct 18, 2023 · 2 comments · Fixed by #578
Assignees
@xunliu @diqiu50 @yuqi1129
Labels
improvement Improvements on everything
Milestone
Graviton v0.2.0

Comments

@jerryshao
Copy link
Contributor

What would you like to be improved?

Currently, trino-connector module doesn't have a mechanism to build a package for trino to leverage our connector. We should add this gradle packaging and documentation support in Gravitino.

Assign to @diqiu50 @xunliu , please figure out a proper way to package and get this done before release.

How should we improve?

No response
@jerryshao jerryshao added the improvement Improvements on everything label Oct 18, 2023
@jerryshao jerryshao added this to the Graviton v0.2.0 milestone Oct 18, 2023
@xunliu
Copy link
Member

xunliu commented Oct 19, 2023 •
edited
Loading

@jerryshao

  1. I think we can package trino-connect-${version}.tar.gz by executing . /gradlew assembleDistribution and then execute . /gradlew publish to push it to https://github.com/datastrato/gravitino/releases.
  2. Or we can used Github Action help me to push trino-connect-${version}.tar.gz to https://github.com/datastrato/gravitino/releases.

I recommend using Github Action.
What do you think?

@jerryshao
Copy link
Contributor Author

I'd suggest we use gradle first so that users could build it themselves. To support github action, I think we can do it later, since we also don't have github action for gravitino release.

@jerryshao jerryshao mentioned this issue Oct 23, 2023
Merged
@yuqi1129 yuqi1129 self-assigned this Oct 24, 2023
@yuqi1129 yuqi1129 mentioned this issue Oct 24, 2023
Merged
jerryshao pushed a commit that referenced this issue Oct 24, 2023
@yuqi1129
[#542] feat(trino-connector): package gravitino trino-connector (#578)
d6c6d92 
### What changes were proposed in this pull request?

- Package `trino-connetor` as
`gravition-trinno-connector-{version}.tar.gz` and put it under
`distribution` directory
- Add docs about `trino-connector` accordingly.

### Why are the changes needed?

We need to package `trino-connector` when releasing `Gravitino` 

Fix: #542 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

No
jerryshao pushed a commit that referenced this issue Oct 26, 2023
@yuqi1129
[#542] feat(trino-connector): package gravitino trino-connector (#578)
074477b 
### What changes were proposed in this pull request?

- Package `trino-connetor` as
`gravition-trinno-connector-{version}.tar.gz` and put it under
`distribution` directory
- Add docs about `trino-connector` accordingly.

### Why are the changes needed?

We need to package `trino-connector` when releasing `Gravitino` 

Fix: #542 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xunliu xunliu

@diqiu50 diqiu50

@yuqi1129 yuqi1129

Labels
improvement Improvements on everything
Projects
None yet
Milestone
Graviton v0.2.0
Development

Successfully merging a pull request may close this issue.

[#542] feat(trino-connector): package gravitino trino-connector yuqi1129/graviton
4 participants
@jerryshao @xunliu @diqiu50 @yuqi1129