Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3207] fix(test): Trigger integration test with changes in module integration-test-common #3201

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

yuqi1129
Copy link
Contributor

@yuqi1129 yuqi1129 commented Apr 29, 2024

What changes were proposed in this pull request?

Trigger integration test when there is a change in module integration-test-common.

Why are the changes needed?

We should start the integration test if there are changes in module integration-test-common. however, CI https://github.com/datastrato/gravitino/actions/runs/8872110159/job/24356012525?pr=3197 of PR #3197 can't start the CI pipeline.

Fixed: #3207

Does this PR introduce any user-facing change?

N/A.

How was this patch tested?

CI passed.

@yuqi1129 yuqi1129 self-assigned this Apr 29, 2024
@qqqttt123 qqqttt123 added 0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 need backport Issues that need to backport to another branch branch-0.5 and removed 0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 labels Apr 29, 2024
@qqqttt123
Copy link
Contributor

I think that this is a fix. If this is a fix, you use an issue to track this. Every fix should track the fixed version.

@qqqttt123 qqqttt123 self-requested a review April 29, 2024 03:35
@yuqi1129 yuqi1129 changed the title [Minor] improvement(test): Trigger integration test with changes in module integration-test-common [3207] fix(test): Trigger integration test with changes in module integration-test-common Apr 29, 2024
@yuqi1129 yuqi1129 changed the title [3207] fix(test): Trigger integration test with changes in module integration-test-common [#3207] fix(test): Trigger integration test with changes in module integration-test-common Apr 29, 2024
@qqqttt123 qqqttt123 merged commit 6e69a91 into apache:main Apr 29, 2024
22 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
…ntegration-test-common` (#3201)

### What changes were proposed in this pull request?

Trigger integration test when there is a change in module
`integration-test-common`.

### Why are the changes needed?

We should start the integration test if there are changes in module
`integration-test-common`. however, CI
https://github.com/datastrato/gravitino/actions/runs/8872110159/job/24356012525?pr=3197
of PR #3197 can't start the
CI pipeline.

Fixed: #3207 

### Does this PR introduce _any_ user-facing change?

N/A.

### How was this patch tested?

CI passed.
@yuqi1129 yuqi1129 deleted the minor branch April 29, 2024 03:40
@qqqttt123
Copy link
Contributor

Thanks @yuqi1129 , merged to main & branch 0.5 for next release.

diqiu50 pushed a commit to diqiu50/gravitino that referenced this pull request Jun 13, 2024
…ule `integration-test-common` (apache#3201)

### What changes were proposed in this pull request?

Trigger integration test when there is a change in module
`integration-test-common`.

### Why are the changes needed?

We should start the integration test if there are changes in module
`integration-test-common`. however, CI
https://github.com/datastrato/gravitino/actions/runs/8872110159/job/24356012525?pr=3197
of PR apache#3197 can't start the
CI pipeline.

Fixed: apache#3207 

### Does this PR introduce _any_ user-facing change?

N/A.

### How was this patch tested?

CI passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-0.5 need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] Gravitino should trigger backend CI pipeleine when module integration-test-common is changed.
2 participants