[#4226] Improvement(python-client): Add Metalake Error Handler and related exceptions, test cases in client-python #4271
Conversation
|
Hi @jingjia88, thanks for your contribution. There seems to be some conflicts between this PR and main branch. |
|
@noidname01 Thanks for reminding. Done! |
jingjia88
changed the title
There was a problem hiding this comment.
@jingjia88 It seems that you don't use this error handler in methods in gravitino_metalake.py and related files.
And please run the tests locally and make sure the tests you write would pass in your local environment.
|
@noidname01 Hi, I have made the changes and run the tests. Could you please review the changes again? Thank you! |
|
@noidname01 Oops, I agree we should use |
There was a problem hiding this comment.
@jingjia88 It seems that your code haven't pass black formatter before commit, please format your code.
| @@ -54,6 +54,9 @@ class InternalError(GravitinoRuntimeException): | |||
| class NotFoundException(GravitinoRuntimeException): | |||
| """Base class for all exceptions thrown when a resource is not found.""" | |||
|
|
|||
| def __init__(self, message, *args): | |||
There was a problem hiding this comment.
I think the __init__ function here is not necessary, because the parent class (GravitinoRuntimeException here) has implemented, except we want some custom features for this class only.
|
@noidname01 Done! Please help to take a look again, Thank you~ |
|
LGTM. |
What changes were proposed in this pull request?
client-pythonbased onclient-javaclient-javaWhy are the changes needed?
Fix: #4226
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT and IT added.