Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4603] fix (test): Fix the OutOfMemoryError in the gradle running testers #4799

Merged
merged 2 commits into from
Sep 1, 2024

Conversation

diqiu50
Copy link
Contributor

@diqiu50 diqiu50 commented Aug 30, 2024

What changes were proposed in this pull request?

Fix the OutOfMemoryError in the gradle running testers

Why are the changes needed?

Fix: #4603

Does this PR introduce any user-facing change?

NO

How was this patch tested?

NO

build.gradle.kts Outdated
@@ -431,7 +431,7 @@ subprojects {
reports.html.outputLocation.set(file("${rootProject.projectDir}/build/reports/"))
val skipTests = project.hasProperty("skipTests")
if (!skipTests) {
jvmArgs = listOf("-Xmx2G")
jvmArgs = listOf("-Xmx3G")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 3G enough to solve the OOM problem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's enough, if not we can increase the size.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems not enough, CI failed in this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to 4G

@jerryshao jerryshao merged commit 5e0d772 into apache:main Sep 1, 2024
27 checks passed
@diqiu50 diqiu50 deleted the inc_memory branch September 13, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] CI: trino-connector:test FAILED on Cron Integration Test 20240820
4 participants